Skip to content

removed non-working dmake project from Visual Studio solution / other dmake related cleanups#7019

Merged
firewave merged 3 commits intocppcheck-opensource:mainfrom
firewave:dmake-vcx
Nov 20, 2024
Merged

removed non-working dmake project from Visual Studio solution / other dmake related cleanups#7019
firewave merged 3 commits intocppcheck-opensource:mainfrom
firewave:dmake-vcx

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

  • tools/dmake/CMakeLists.txt: properly specify utils.cpp
  • iwyu.yml: added TODO about unnecessary dmake build
  • removed non-working dmake project from Visual Studio solution

@firewave
Copy link
Copy Markdown
Collaborator Author

dmake.vcxproj was never maintained or properly hooked up in the Visual Studio solution. Having it behave as in CMake was not straight forward so I never hooked it up when I integrated in the project. It also hasn't built in months. So since nobody has ever complained about this it makes no sense to maintain this.

@firewave firewave changed the title some dmake related cleanups removed non-working dmake project from Visual Studio solution / other dmake related cleanups Nov 17, 2024
@firewave firewave changed the title removed non-working dmake project from Visual Studio solution / other dmake related cleanups removed non-working dmake project from Visual Studio solution / other dmake related cleanups Nov 17, 2024
Copy link
Copy Markdown
Collaborator

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we originally just wanted that cppcheck developers that used dmake would be able to compile and run dmake if they was changing dependencies..

I guess I have never used it.

having it only in cmake sounds fine to me.

@firewave firewave merged commit 8f40b82 into cppcheck-opensource:main Nov 20, 2024
@firewave firewave deleted the dmake-vcx branch November 20, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants